Skip to content

feat(lib): Add a workaround for Header#3388

Open
louismaximepiton wants to merge 9 commits intoouds/mainfrom
ouds/main-lmp-better-header
Open

feat(lib): Add a workaround for Header#3388
louismaximepiton wants to merge 9 commits intoouds/mainfrom
ouds/main-lmp-better-header

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 24, 2026

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Related to #3346.

Context & Motivation

Read #3346.

Description

Tweak a bit the variables of the navbar and add the according documentation.

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1bc7642
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/69c10feefa15b200080a613f
😎 Deploy Preview https://deploy-preview-3388--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review February 25, 2026 08:44
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Feb 25, 2026
@louismaximepiton louismaximepiton marked this pull request as draft March 6, 2026 09:47
@louismaximepiton louismaximepiton linked an issue Mar 11, 2026 that may be closed by this pull request
2 tasks
@louismaximepiton louismaximepiton marked this pull request as ready for review March 17, 2026 10:43
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion but it's all good.
Tbh the simple changes in alignment make it look way better.

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Mar 18, 2026
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion on migration

Co-authored-by: Maxime Lardenois <maxime.lardenois@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css 📖 documentation Improvements or additions to documentation

Projects

Status: Need Lead Dev Review

Development

Successfully merging this pull request may close these issues.

[OUDS] Header and Footer draft component

4 participants